Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for v1.23 #15443

Merged
merged 13 commits into from
Jul 23, 2024
Merged

prepare for v1.23 #15443

merged 13 commits into from
Jul 23, 2024

Conversation

dhawton
Copy link
Member

@dhawton dhawton commented Jul 18, 2024

Description

Prepare for 1.23 release

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Signed-off-by: Daniel Hawton <[email protected]>
@dhawton dhawton requested review from a team as code owners July 18, 2024 15:28
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2024
@dhawton
Copy link
Member Author

dhawton commented Jul 18, 2024

/retest

@dhawton
Copy link
Member Author

dhawton commented Jul 18, 2024

/test doc.test.profile-default

@dhawton
Copy link
Member Author

dhawton commented Jul 18, 2024

/test doc.test.profile-ambient

@dhawton dhawton requested a review from a team as a code owner July 18, 2024 20:31
Signed-off-by: Daniel Hawton <[email protected]>
@dhawton
Copy link
Member Author

dhawton commented Jul 18, 2024

/test doc.test.profile-ambient

extend wasm flake

@dhawton
Copy link
Member Author

dhawton commented Jul 18, 2024

/test doc.test.profile-demo

@craigbox
Copy link
Contributor

craigbox commented Jul 19, 2024

/retest

Failing tests:

  • default
    • test output includes errors relating to istioctl x wait being removed
      • Error: unknown flag: --for - possibly related to the istioctl x wait command changing in 1.23?
      • On 1.22, when running istioctl experimental wait --for=distribution I get Error: unable to query pilot for distribution (are you using pilot version >= 1.4 with config distribution tracking on): unexpected status code: 409; when running with -vklog 9, it actually gets a 101 Switching Protocols error, which appears to be when upgrading to websockets and may be related to IPv6?
    • the actual failure appears to be the output has extra semi-colons in it. investigating if this is a change in Envoy output or if for some reason the hostname has a semicolon suffixed.
  • none:
    • config-resource-ready
      • relates to a feature that has been removed; the whole page just needs to be removed
    • dns-proxy
      • possibly due to IPv6 being in 1.23?
    • canary upgrade
      • flaky scripting: the awk fetches the 10th token, though this will differ based on SYNCED (1 token) or NOT SENT (2 tokens) being output.
$ istioctl proxy-status | grep "$(kubectl -n istio-system get pod -l app=istio-ingressgateway -o jsonpath='{.items..metadata.name}')" | awk '{print $10}'
istiod-77d7cbcfdb-npn7p
$ istioctl proxy-status | grep "$(kubectl -n istio-system get pod -l app=istio-ingressgateway -o jsonpath='{.items..metadata.name}')" 
istio-ingressgateway-857d9d77f7-xq5hr.istio-system     Kubernetes     SYNCED     SYNCED     SYNCED     NOT SENT     NOT SENT     istiod-77d7cbcfdb-npn7p     1.22.2
$ istioctl proxy-status 
NAME                                                   CLUSTER        CDS        LDS        EDS        RDS          ECDS         ISTIOD                      VERSION
istio-ingressgateway-857d9d77f7-xq5hr.istio-system     Kubernetes     SYNCED     SYNCED     SYNCED     NOT SENT     NOT SENT     istiod-77d7cbcfdb-npn7p     1.22.2
sleep-7656cf8794-q2g6d.default                         Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED       NOT SENT     istiod-77d7cbcfdb-npn7p     1.22.2
$ istioctl proxy-status | awk '{print $10}'

istiod-77d7cbcfdb-npn7p
1.22.2

There's no JSON output for istioctl - someone proposed it but it was never merged. So instead I propose the rather hacky-looking:

istioctl proxy-status | grep "$(kubectl -n istio-system get pod -l app=istio-ingressgateway -o jsonpath='{.items..metadata.name}')" | awk -F '[[:space:]][[:space:]]+' '{print $8}'

@bleggett bleggett mentioned this pull request Jul 19, 2024
11 tasks
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@dhawton
Copy link
Member Author

dhawton commented Jul 22, 2024

dns-proxy page failure is in the section about Auto Allocation.. which received a few changes in 1.23. I don't believe this is related to dual stack, as the SE above the auto allocation does pass the test.

@craigbox
Copy link
Contributor

craigbox commented Jul 22, 2024

/retest

Latest links:

  • DNS proxy
  • authz-tcp - flake? The page literally has a warning under this snip which says "If you don’t see the expected output, retry after a few seconds. Caching and propagation can cause a delay."
  • circuit breaking - the page/snips were updated, this test output doesn't reflect that. Fixed, needed to update the test as it doesn't use the _out

@dhawton
Copy link
Member Author

dhawton commented Jul 23, 2024

/test doc.test.profile-ambient

Flake

@dhawton
Copy link
Member Author

dhawton commented Jul 23, 2024

/test doc.test.profile-ambient

@craigbox
Copy link
Contributor

/test doc.test.profile-none

Might be a flake even though it's also in the DNS Proxy page. It looks like it just didn't get programmed in time.

@dhawton
Copy link
Member Author

dhawton commented Jul 23, 2024

/test doc.test.profile-none

Might be a flake even though it's also in the DNS Proxy page. It looks like it just didn't get programmed in time.

No.. it's another change in istioctl. I have disabled that validation for now.. I'll take a look at both first thing in the AM, but as long as we fix before 1.23.0 it should be ok to disable for now.

@craigbox
Copy link
Contributor

No.. it's another change in istioctl.

Cool. (I tried testing with 1.23.0-alpha.0 which still had the same output.)

@istio-testing istio-testing merged commit f103be6 into istio:master Jul 23, 2024
13 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Jul 23, 2024
istio-testing pushed a commit that referenced this pull request Jul 24, 2024
* Sync #15443 prepare for 1.23 update into Chinese

* fix
@howardjohn howardjohn mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants